[MERGE] is_ignored improvements...

Robert Collins robertc at robertcollins.net
Fri May 19 06:40:16 BST 2006


I've had some further thoughts on this optimisation...

I think we might get better performance still if we grouped the basename
only matches into one regex:

Rather than translating
["foo", "foo/bad", "bar*"] into

"((?:.*/)?(?!.*/)foo$)|((?:.*/)?(?!.*/)bar.*$)|(foo/bad$)"

if we translated that as
"(?:(?:.*/)?(?!.*/)(?:(foo)|(bar.*))|(foo/bad))$"

it would mean there is only one negative lookahead assertion in the
entire group. This will require reordering of the ignore rules to
combine them like this, but I think thats worth it (as a second step
optimisation).

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060519/d81ade90/attachment.pgp 


More information about the bazaar mailing list