When format 5 isn't format 5

[Robert Collins]

On Tue, 2006-05-16 at 10:37 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi all,
> 
> In updating changeset code, I've discovered that our inventory format
> has changed, without changing its version number.
> 
> Specifically, new format 5 inventories contain a revision ID, and older
> ones do not.  It looks like this change was introduced by Robert's patch
> to get rid of the trailing revision-id in basis-inventory filenames.  I
> presume that it was intended that only basis inventories would include
> revision-ids, but it's also been applied inventories in the inventory weave.

Actually, thats Johns patch :)>. I just merged it.

> Revision testaments contain the inventory hash, which I believe is just
> the inventory XML SHA1 hash.  This means that fixing existing
> repositories would break signatures.
> 
> Among other things, this strongly suggests that our unit tests should
> include a test to make sure we get a reproduceable testament when we
> commit a revision with fixed values.

I agree.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060519/add8315d/attachment.pgp