[merge] FTP now has and passes regression tests

[John Arbash Meinel]

Wayne Davison wrote:
> In the split_url() function, it would be nice if it would prompt the
> user for a password if no ':' was found in the hostname.  This would
> handle the normal case safely, while forcing someone who wanted an empty
> password (and no prompt) to append a trailing ':' onto the hostname
> (which seems like a fringe case).
> 
> For instance, if something like this were added right before the return:
> 
>     if password == None:
>         password = bzrlib.ui.ui_factory.get_password(
>                     prompt='FTP %(user)s@%(host)s password',
>                     user=username, host=host)
> 
> Doing this should fix bug 34685.
> 
> ..wayne..
> 

I finally found an ftp server to test pushing data to, and it gives the
worst error messages, basically just saying "your request failed".
Anyway, I added some default exception classes, to make it easier to
catch and then debug the problem. (Also, ftp was trying to SITE CHMOD
stuff to 0000 which it shouldn't do).

With the attached patch on top of my other changes, I was able to push a
small bzr branch onto an ftp server, including having it prompt me for
my password.

The branch is still at:
http://bzr.arbash-meinel.com/branches/bzr/ftp-server/

(currently revno 1733).

John
=:->

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ftp-default.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20060516/1484a10b/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060516/1484a10b/attachment.pgp