[merge] FTP now has and passes regression tests

Wayne Davison wayned at samba.org
Tue May 16 23:56:45 BST 2006


In the split_url() function, it would be nice if it would prompt the
user for a password if no ':' was found in the hostname.  This would
handle the normal case safely, while forcing someone who wanted an empty
password (and no prompt) to append a trailing ':' onto the hostname
(which seems like a fringe case).

For instance, if something like this were added right before the return:

    if password == None:
        password = bzrlib.ui.ui_factory.get_password(
                    prompt='FTP %(user)s@%(host)s password',
                    user=username, host=host)

Doing this should fix bug 34685.

..wayne..




More information about the bazaar mailing list