bzr-webserve bug

[Goffredo Baroncelli]

On Tuesday 16 May 2006 23:57, you (John Dong) wrote:
> Hey, would just like to complement you on the great work that is
> bzr-webserve. 
Thanks


> I've found a small bug:
> webserve does not correctly handle e-mail addresses with special HTTP URL
> characters. For example, '+' is a perfectly valid character for e-mail
> addresses, but webserve will generate URL's like this:
> 
http://localhost:8088/?cmd=revision;revid=john.dong+bzr.laptop@gmail.com-20060311170718-a0a2afacd6e2f7b7
> 
> The plus sign will be treated as a special character and it will cause the
> revision to be unfindable. Webserve needs to escape URL's when generating
> them, and un-escape them when parsing a URL.

I understand the point; the first solution that I see is to escape the 
revision_id...

I think that in the week I will post a patch.

Thank for the report.
 
Goffredo

-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9