[patch][win32] improved(2) win32 packaging patch + [rfc]

[Alexander Belchenko]

Martin Pool пишет:
> On 10 May 2006, Alexander Belchenko <bialix at ukr.net> wrote:
>> I rework my patch for win32 packaging stuff.
[skip]
> 
> +1 from me, anyone else?

I seeking another +1 for my installer work.

Here new version. Changes from previous version:

* Fixes for the bug 44095 [1]
   When mfc71.dll will not found during installation special warning
   message will be shown [2]
* Improved installer: more metadata information (contact information,
   version of installer itself), don't need to reboot system if bzr
   installation directory added to PATH.
* Translation txt documentations to html: provided compatibility with
   docutils 0.4
* Makefile: added target 'clean_win32' for cleaning on win32.

I pull latest changes of bzr.0.8 branch and make new version of 
installer for the testing pleasure [3]. I call new installer as 0.8.1pre 
because there is no official announce of 0.8.1.

I start to write document with detailed instructions on how to make 
installer [4].


[RFC]
I also have 2 related questions. I hope this questions won't block 
merging of my patch.

1. Do installer should show License page with blocking installation when 
user choose "No, I don't agree with license"? If this step (license 
agreement) is mandatory then I need to have text of license to put into 
bzr source tree and inside installer. Adding this step is easy enough. 
(BTW, Mercurial installer for Windows has this step).

2. On some sites I read *legal warnings* that cryptographic libraries 
and SSH tools might be illegal in some countries. At least on Putty page 
[5] I see similar warning.  At this moment windows installer include all 
possible libraries that require bzr to work in different modes. And 
includes paramiko + pycrypto. I'm not lawyer so I ask to core 
developers, in particular to Martin: is this important issue? If this 
important then we probably could deal by one of two variants:

a. Make 2 versions of installer (basic version -- without paramiko, and 
full version with paramiko)
b. Make one big version and give to user choice to select what 
components to install.

Variant b) is harder to implement. Variant a) only require 2 times more 
room on the download server.


Links:

[1] https://launchpad.net/bugs/44095
[2] http://bzr.onembedding.com/bzr.win/0.8.1/check_mfc71.dll.png
[3] http://bzr.onembedding.com/bzr.win/0.8.1/bzr-setup-0.8.1pre.exe
[4] http://bazaar-vcs.org/BzrWin32Installer
[5] http://www.chiark.greenend.org.uk/~sgtatham/putty/download.html


--
Alexander