[MERGE REVIEW] Move BzrBranch.get_revision_delta to Branch
John A Meinel
john at arbash-meinel.com
Tue May 9 05:16:43 BST 2006
Aaron Bentley wrote:
> Jelmer Vernooij wrote:
>> Any chance somebody could have a look at this patch and approve it or
> I don't like this method much, as I prefer the minimal-but-complete
> approach to object interfaces, and Branch definitely does not have that.
> It has only one caller in the bzr codebase, so I'd welcome
> deprecating it, though others would doubtless disagree.
> Still, I'd hate for there to be multiple implementations of it. Your
> port of the method from BzrBranch to Branch looks fine. +1 from me.
> On the other hand, there are some issues with the method itself. Fixing
> those issues would be nice, but not required for a merge.
I also prefer a more minimal Branch, which is why I delayed approval of
the original change. I was hoping for it to be restricted to log.py
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060508/bf2e85fc/attachment.pgp
More information about the bazaar