A question about uncommit

[Wayne Davison]

I had a reason to do an uncommit today, and ended up having some
questions.  First, I noticed that the uncommit does not actually
remove the data from the committed changes, just some "pointer"
files -- i.e. the ID in branch/revision-history changed, the XML
inventory in checkout/basis-inventory changed, and the ID in
checkout/last-revision changed, but nothing else.  There is an
option listed for the uncommit sub-command that looks like it was
supposed to change this, but it doesn't work (--all is rejected).

FYI, I'm using a freshly-created knit branch created by bzr 0.8.

So, is this supposed to work this way?  In looking around, it would
seem the answer to this is "yes".  If so, is there a command planned
to clean out any old, useless revision data?  Perhaps something like
John's old clean-weave plugin (but presumably merged into bzr)?

Bonus: since "uncommit --all" does not work anymore, attached is a
patch to remove the mention of the --all option.

..wayne..
-------------- next part --------------
--- bzrlib/builtins.py	
+++ bzrlib/builtins.py	
@@ -2394,10 +2394,6 @@
 class cmd_uncommit(bzrlib.commands.Command):
     """Remove the last committed revision.
 
-    By supplying the --all flag, it will not only remove the entry 
-    from revision_history, but also remove all of the entries in the
-    stores.
-
     --verbose will print out what is being removed.
     --dry-run will go through all the motions, but not actually
     remove anything.