[PATCH] checkout --light

[Olaf Conradi]

On 18/04/06, David Allouche <david at allouche.net> wrote:
> I love light checkouts. And I'm too lazy to call them "lightweight".
>
> So I would like the command to create them to change from "bzr co
> --lightweight" to "bzr co --light", so much less finger wear.
>
> This is accomplished by the attached patch. The patch also does some
> minor fixes to the docstring, accounting for the bulk of the diffs:
>
>       * turn the reference to the non-existent basis option into a
>         comment, so it does not appear in the help text
>       * reflow the docstrings so they do not go past column 79.

+1 on --light option and would like to see --heavy too

Some minor comments on the reflowing:

+    If BRANCH_LOCATION is omitted, checkout will reconstitute a working tree

+    for the branch found in '.'. This is useful if you have removed the working

+    tree or if it was never created - i.e. if you pushed the branch to its

+    current location using SFTP.


If we are changing it, I'd rather have this changed to:

+    If BRANCH_LOCATION is omitted, checkout will reconstitute a working tree

+    for the branch found in the current directory. This is useful if you have

+    removed the working tree or if it was never created, i.e. if you pushed

+    the branch to its current location using SFTP.


This changes '.' to current directory, and removes the dash in front of i.e.

I don't really like how you reflowed this:

+    takes_options = ['revision', # , 'basis',

+                     Option('light', help=(

+        "create a light checkout. Light checkouts depend on access to the "

+        "branch for every operation. Normal checkouts can perform common "

+        "operations like diff and status without such access, and also "

+        "support local commits.")),

+                    ]


I'd rather see the original indenting, but aligned to 80:

+    takes_options = ['revision', # , 'basis']

+                     Option('lightweight',

+                            help="perform a lightweight checkout. Lightweight"

+                                 " checkouts depend on access to the branch"

+                                 " for every operation. Normal checkouts can"

+                                 " perform common operations like diff and"

+                                 " status without such access, and also"
+                                 " support local commits."

+                            ),

+                     ]



Cheers
 -Olaf