[PATCH] send external diff to a file (bug 4047)

[James Henstridge]

On 5/5/06, Martin Pool <mbp at sourcefrog.net> wrote:
> On 05/05/2006, at 5:12 PM, James Henstridge wrote:
> > If the recommended style has changed, I can fix things up.
>
> The general rule is to put them at the top level unless either:
>
>   - importing them later would substantially reduce the cost
>   - or importing them later is the best way to resolve a dependency
> cycle

Okay.  I'll move the imports outside of external_diff().  From what I
can tell the two modules in question get imported unconditionally in
most cases anyway:
 * tempfile in bzrlib/osutils.py
 * subprocess in bzrlib/gpg.py which gets imported unconditionally by
bzrlib/repository.py

I've moved the imports out of external_diff() in my branch now (at
revision 1696).

James.