[patch] update of alexander's rmtree patch

Martin Pool mbp at sourcefrog.net
Fri May 5 02:16:43 BST 2006


On  4 May 2006, Alexander Belchenko <bialix at ukr.net> wrote:
> Martin Pool пишет:
> >This is an update of Alexander's patch posted last month to take account
> >of shifts in bzr.dev.   Alexander, is there anything else you strongly
> >want merged for 0.8?
> 
> This patch show that you want make this rmtree-read-only approach as
> bzrlib default method. Well, probably you're right. So I'm strongly
> positive for that.
> 
> Now I have not another urgent patches and willing to start to make win32
> bzr.exe and installer.

Great.

I found one more thing after I sent this patch though - the test for
osutils.rmtree tries to delete a readonly directory containing a
readonly file.  This doesn't work using python's rmtree, which is what
we use on posix - we'd need to write a replacement that makes the
directory writeable before trying to remove things inside it.  

For now I'm just going to stub this out of the test and test only
removal of a tree containing readonly files.

-- 
Martin




More information about the bazaar mailing list