[PLUGIN] bzr_difftools fixes

[Stephen Ward]

On Thursday 04 May 2006 01:58, you wrote:
> I'm not sure I like the prompting when there's lots of files, where
> lots > 1. Perhaps you can just print out "Diffing n files ..." then at
> least the user knows why it's taking a while. And better still make it
> interruptable so I can ctrl-c it.

I would love to make it easily interruptable, but as Martin pointed out, there 
are some problems when the diff tool grabs your terminal.  If vim ever 
returns something that is recognizable as an error code, I suppose I could 
check that...

Failing that, I only see three alternatives:

1. no confirmation request (the original behavior)
2. confirmation request before diffing "lots" of files (current behavior)
3. confirmation request after each file

The 1st option is a problem, because 'bzr diff --using vim' with no other 
arguments would diff the whole tree; that is really annoying if you simply 
forgot to type the filename you really wanted.

The 3rd option is a bad choice because it constantly interrupts your work flow 
if you actually *wanted* to see all the diffs.  I could certainly implement 
that, if enough people prefer it anyway, but personally I would find this 
constant "tell me again" horribly annoying. 

So that leaves the 2nd option, and the main question is what the threshold 
should be.  Right now, it is "num > 1".  I could see making the threshold 2, 
or 3, or 5, but I doubt it should go much higher than that.

I could also make the threshold configurable, of course, but it needs to have 
a sane default.


> Also it'd be nice to do something prettier when the tool isn't found:
> ...

Easily fixed.

-- Steve