[PLUGIN] bzr_difftools fixes
Martin Pool
mbp at sourcefrog.net
Thu May 4 08:13:29 BST 2006
On 4 May 2006, Michael Ellerman <michael at ellerman.id.au> wrote:
> On 5/3/06, Stephen Ward <sward.dev at verizon.net> wrote:
> >Hi,
> >
> >I've updated the bzr_difftools plugin with the following fixes:
>
> This rocks, nice work.
>
> >* added a confirmation check before iteratively diffing the entire
> >contents of
> >a tree (still can't break out easily once the loop gets going, however).
>
> I'm not sure I like the prompting when there's lots of files, where
> lots > 1. Perhaps you can just print out "Diffing n files ..." then at
> least the user knows why it's taking a while. And better still make it
> interruptable so I can ctrl-c it.
The difficulty is if you're using something like vimdiff it absorbs C-c
and starts quite quickly so there is not much of a chance to get the
interrupt through. (You can switch to another window or screen,
find python's pid and kill it, but that's a bit crude.)
> Also it'd be nice to do something prettier when the tool isn't found:
>
> $ bzr diff -r -2.. --using mgdiff
> There are 2 files with differences to review
> Do you wish to continue [Y/n]?
> bzr: ERROR: exceptions.OSError: [Errno 2] No such file or directory
> at /usr/lib/python2.4/subprocess.py line 975
> in _execute_child
>
> cheers
--
Martin
More information about the bazaar
mailing list