[PATCH] Very trival patch to make use of alternatives system

Martin Pool mbp at sourcefrog.net
Thu May 4 02:40:39 BST 2006


On 04/05/2006, at 11:10 AM, John Arbash Meinel wrote:

> Olaf Conradi wrote:
>> On 04/05/06, Olaf Conradi <oohlaf at gmail.com> wrote:
>>> Patch attached.
>>
>> Aargh, forgot to clean the environment in the test case,
>> New patch attached, sorry for the noise on the list.

+1, but not for 0.8, with one correction:

Debian's policy explicitly says it must run /usr/bin/editor, not  
editor from the $PATH.  (If we're going to follow the standard we  
might as well be precise.)

Please file a bug with this attached so it's not lost; we can merge  
it tomorrow or next week.

> Are you sure we want to use VISUAL? My biggest concern is that it will
> disconnect from the terminal (like gvim without -f). Which means that
> commit would always fail.
>
> bzr seems like something that would expect a terminal program first.
>
> But I'll leave it to someone who knows what the Debian policy is.  
> If it
> is indeed to use VISUAL, then +1 from me.

As far as I know VISUAL does not imply the process will detach.  I  
thought it was originally about e.g. vi vs ed, being suitable for  
fullscreen terminals.

-- 
Martin







More information about the bazaar mailing list