[win32] Permission denied in fancy_rename

[Martin Pool]

On  1 May 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> Alexander Belchenko wrote:
> > Dear core developers! Don't leave files opened after use! Please, close
> > them explicitly! Or bzr always has minor issues on windows platform.
> 
> Unfortunately, I only became aware of this issue when you posted about
> it very recently.  So until then, everything I'd written had unclosed
> files.  I wouldn't be surprised if the same is true for others, but the
> reminder can't hurt.

Even on Unix we must close files - otherwise there is no guarantee that
the content will actually have been written out from Python's buffers.
I'm sure I mentioned that in a review once, but we should add it to the
hacking guidelines.

-- 
Martin