[PATCH] knit pushing with ftp transport

[John Arbash Meinel]

Alexandre Saint wrote:
> Hello,
> 
> This patch adds support for knit format to the ftp transport.
> 
> Added an append() method using FTP 'APPE' command.
> Modified copy() to deal well with relative paths (and not only with
> absolute ones).
> 
> Regards.
> 
> 

I just realized something while looking over this code. Did we ever
specify that the File-like object needs to be seekable? And that we must
be able to backtrack? (One example is you cannot seek stdin).

Since the line where you copy the bytes is just doing:
	conn.sendall(f.read())
I'm wondering if it wouldn't be better to change things, and have the
helper function (which gets retries), take a string buffer, rather than
seeking on the file object.

Other than that, +1 from me.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060430/eb7dc409/attachment.pgp