[PATCH] Bug in msgeditor in latest bzr.dev

[John Arbash Meinel]

Olaf Conradi wrote:
> After changing the platform test, import of module sys was forgotten.
> This breaks checking in.
> 
> Cheers
> -Olaf

Bug confirmed, and +1 to the patch. Because it disallows committing if
EDITOR and BZR_EDITOR are not set, I'll merge it right away.

John
=:->

> 
> === modified file 'a/bzrlib/msgeditor.py'
> --- a/bzrlib/msgeditor.py
> +++ b/bzrlib/msgeditor.py
> @@ -17,12 +17,15 @@
> 
> """Commit message editor support."""
> 
> +

I don't think this space needs to be there. I do believe it is only 1
space between the doc string, and the first import. But it is a little
bit hazy. And while we are here, we should sort the imports
alphabetically, but I'll fix that.

> import os
> +import sys
> import errno
> from subprocess import call
> 
> import bzrlib.config as config
> from bzrlib.errors import BzrError
> +
> 
> def _get_editor():
>     """Return a sequence of possible editor binaries for the current
> platform"""
> 
> 

Thanks for catching the bug.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060429/28f1b065/attachment.pgp