"Using Saved Location: foo"

John Arbash Meinel john at arbash-meinel.com
Thu Apr 27 14:42:29 BST 2006


I was wondering what the most appropriate thing to print for "using
saved location" would be.
For proper URLs (like http/sftp/etc), I guess it makes sense to just
print the escaped path.
But for local file URLs, it seems like it would be nicer to display the
actual Unicode path.

I did convert the code so that it saves the file url into
.bzr/branch/parent to do a little of the work to support not unicode paths.

For now, I'm just going to display whatever URL we have saved as the
parent. I just wanted to bring it up for discussion.

The other thing I changed was relative paths versus absolute paths in
.bzr/branch/parent

The old code would save exactly what was typed by the user. And it
actually would save the value *before* the command was actually
executed. So if you typed
	bzr pull --remember ../otherr

It would save "../otherr" as the parent, even though the pull would fail.
I changed the code to wait until the other branch has been connected,
and then use "branch.base". Which returns the absolute path.

Is it better to have ".bzr/branch/parent" be exactly what the user typed
(a relative path, etc). And is it better to do it right away rather than
after we have successfully contacted the other branch?

(This also affects missing, merge, anything that calls Branch.set_parent())

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060427/9e899ce2/attachment.pgp 


More information about the bazaar mailing list