URL consistency
John Arbash Meinel
john at arbash-meinel.com
Thu Apr 27 02:55:27 BST 2006
I'm working on making LocalTransport only accept URLs, and process
everything internally as a URL. In general, it actually seems to work well.
One thing it does flush out is all of the locations where we were
passing the paths to Transport rather than passing URLs.
I now have most of the tests passing. So if people want to give it a
lookover it would be nice to get it reviewed.
Not all of the commands have been updated for the new "Command.outf"
change, and there are a bunch of places where I introduced some
deprecation warnings (I deprecated passing a plain path to
LocalTransport, recommending to go through get_transport instead).
If we ever want to support having non-unicode in our path, then we
probably need to break our paths into 2 components. First is the base
component, which we will preserve exactly as we got it, and second is
the sub-component, which will be required to either be unversioned or
unicode.
Right now local_path_to_url and local_path_from_url assume that the
entire path is utf-8 encoded and url escaped.
As of revision 1701 the score is:
Ran 2325 tests in 364.911s
FAILED (failures=37, errors=1)
The biggest reason being code that assumes LocalTransport.base is a
local filesystem path and not a URL. (And a lot of that is just test
bugs, not actual code bugs).
John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060426/85fbf94f/attachment.pgp
More information about the bazaar
mailing list