[MERGE] Win32 fixes

Aaron Bentley aaron.bentley at utoronto.ca
Fri Apr 21 15:31:04 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Actually, ' is a valid character on a windows path. And I'm sure we want
> to support forward slashes instead of requiring back slashes. I thought
> internally all paths were forward slashed anyway. 

Sure.

> And at the point we
> are at, the path is an absolute path, so I would change it to:

I want to move it into osutils, and have a single 'is this path going to
give Windows a fit?' check, so I'd rather make the leading drive optional.

> _validWin32PathRE = re.compile(r'^[A-Z]:/[^:<>*"?\|\\]*$')
> If we want to support either slash form, then it would be
> _validWin32PathRE = re.compile(r'^[A-Z]:[/\\][^:<>*"?\|]*$')

Yes, we should support either kind of slash.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFESOyo0F+nu1YWqI0RAi/RAJ40I4KR4Q3A0zxcW0fgA1eF8g3sqgCfWiLR
7LJMZLiDiu93pgyXfleCJag=
=I/jF
-----END PGP SIGNATURE-----




More information about the bazaar mailing list