[MERGE] Win32 fixes

Aaron Bentley aaron.bentley at utoronto.ca
Fri Apr 21 15:02:02 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> There are a *lot* more illegal characters than just '<>'. The list I
> always remember is '\/?<>":*|'

Sure.  My primary motivation was justifying skipping tests that used '<>'.

> So we either need to treat ':' specially (as in make sure it is in the
> beginning, but doesn't exist in the rest of the path). Or just punt for now.

So would this be a good way of detecting a *legal* windows path?

re.match('([A-Z]:\\\\)?[^:<>*\"\'?]*$', 'C:\\ee')

> But since baz-import uses 'Arch:foo' it would be a lot nicer for the
> user to get an IllegalPath exception, than some random OS error. 

Yes, it's pretty random, alright.  It looks like ENOENT!  Why oh why
can't they give us a reasonable errno, so we don't have to predict
what's valid?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFESOXa0F+nu1YWqI0RAmClAJ9BRJd03bfJUlXCzMrystMM3Fqf1wCbB9oj
i7+QgAwiZ+LcJyTymbuzxpY=
=x2XE
-----END PGP SIGNATURE-----




More information about the bazaar mailing list