[patch] lockdir contention detection on sftp

[Robert Collins]

On Wed, 2006-04-19 at 18:10 +1000, Martin Pool wrote:
> At present sftp operations raise NoSuchFile if they get a generic
> failure message.  This means that lock contention over sftp isn't
> properly detected as such, and in general it seems a bit strange to
> assume NoSuchFile is best.
> 
> This patch is one way to fix it: raise a generic PathError if we get a
> generic failure from sftp.  Another way would be to treat any
> transport-related error while trying to take the lock as possibly
> indicating contention.

Perhaps it should raise TransportError not PathError - PathError is a
BzrNewError, but not a TransportError.

Or perhaps we should have PathError be a TransportError.

I mention this because it seems desirable that all the errors raised
from Transport be TransportErrors.

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060420/c9c7015a/attachment.pgp