[PATCH] fix bound branch SFTP test speed, and optimise somewhat.

[Robert Collins]

Is there any chance you could trim your reviews somewhat ? Hard to fine
the actions vs quoted text.

On Wed, 2006-04-19 at 15:38 +1000, Martin Pool wrote:
> On 26/03/2006, at 7:50 AM, Robert Collins wrote:
> 
> > I've done a mini optimisation pass over the bound branch section of  
> > the
> > test suite. There are some clearly right things:
> >
> >  * reduce lock-unlock sequences in WorkingTree disk construction.
> >  * fix the 5 second timeout that was triggering in the bound branch  
> > SFTP
> > tests.
> >

>  > +def clear_connection_cache():
>  > +    """Remove all hosts from the SFTP connection cache.
>  > +
>  > +    Primarily useful for test cases wanting to force garbage  
> collection.
>  > +    """
>  > +    while _connected_hosts:
>  > +        _connected_hosts.popitem()
> 
> Is thee any reason why this is not just _connected_hosts.clear()?
> (If so, add a comment, so it's not changed unknowingly.)

No reason, my being slack. Fixing

>  >

> 
> There seems to be a window of statements run with control_files  
> locked but guarded by a try/finally block.  Isn't that a problem?

if it fails in there then there is an invalid checkout created. We want
that locked rather than unlocked-and-invalid.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060419/b57b2857/attachment.pgp