[Bug 36963] Re: [Bug 36963] [patch] #36963 better messages on commit
mbp at sourcefrog.net
Wed Apr 19 06:42:09 BST 2006
On 19/04/2006, at 3:12 PM, Robert Collins wrote:
>> - def _get_snapshot_change(self, previous_entries):
>> + def _describe_snapshot_change(self, previous_entries):
>> + """Describe how this entry will have changed in a new
>> + :param previous_entries: Dictionary from revision_id to
>> inventory entry.
>> + :returns: One-word description: "merged", "added",
>> "renamed", "modified".
>> + """
>> + # XXX: This assumes that the file *has* changed -- it
>> should probably
>> + # be fused with whatever does that detection. Why not
>> just a single
>> + # thing to compare the entries?
> because the detection occured in multiple places and ways at the time
> this code was written . Thus this helper was factored out to remove
> duplicate code. Also it kept the size of the functions it was factored
> out from from being insane.
I can well believe it's clearer than before - the question was more
about combining it with other inventory-comparing operations such as
So, thanks, I'll send a merge request.
More information about the bazaar