[MERGE REVIEW] New output for bzr info with API test case

Olaf Conradi olaf at conradi.org
Tue Apr 11 18:29:56 BST 2006


On 11/04/06, Martin Pool <mbp at sourcefrog.net> wrote:
> +1, looks good.

Cool

> Some more suggestions:
>
>   - the help string for bzr info (in cmd_info) should say more about
> what will be displayed

OK, how about this:

    """Show information about a working tree, branch or repository.

    This command will show all known locations and formats associated to the
    tree, branch or repository.  Along with statistical information for each.

    Branches and working trees will report missing revisions.
    """
    takes_args = ['location?']
    takes_options = ['verbose',
                     Option('local', help="show only local information"),
                     ]

>   - I think these changes mean that bzr info will always try to
> access the repository, and so the command won't work when you're in
> e.g. a checkout and not connected.  Perhaps there could be a --local
> option.

A checkout (bound branch) has a local repository. Only the missing
revisions check will contact a possibly remote bound master branch.

For lightweight checkouts with a remote branch and repository on sftp,
the open_workingtree accesses paramiko already.

working = a_bzrdir.open_workingtree() will give an exception as
__init__ in WorkingTree also calls open_branch()

So you want --local to skip the missing master revisions check when bound?

> I'll merge in what you already have.

Thanks
 -Olaf




More information about the bazaar mailing list