Download progress
Aaron Bentley
aaron.bentley at utoronto.ca
Mon Apr 10 17:45:33 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Okay, here's what I've got for download progress:
1. For transports which do most of their work in f.readlines(), we use
progress_readlines() to do the readlines operation
2. For transports which do most of their work in _get(), we do a
standard readlines().
3. For PYCURL, we supply a progress callback. Other transports that do
all their work in _get() will need something similar done.
Unfortunately, PYCURL appears to mess with the system clock, causing
throttle to improperly throttle everything. So now ChildProgress
objects can demand not to be throttled. Seems like a hack; don't know
another option. This should be avoided where possible.
I didn't make throttling a global setting, because it's only required in
certain contexts. I didn't move throttling into ChildProgress, because
children can be created and destroyed rapidly, preventing throttling
from taking effect.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFEOout0F+nu1YWqI0RAsQjAJ0SikJuhrQ4ho4X98GJyg/lgWm31ACfZEux
ioCsFxeoXk8d0iRgr73oNzo=
=77T0
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: download-progress.patch
Type: text/x-patch
Size: 6075 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060410/b7a33113/attachment.bin
More information about the bazaar
mailing list