[MERGE REVIEW] progress bars for tree builds

[Robert Collins]

On Thu, 2006-04-06 at 23:15 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> 
> | The use of PP suggests there are two phases. But I can only see one
> | phase occuring - the next phase calls occur before and after the only
> | loop, and no pb calls occur after that.
> 
> The first phase is the transform preparation, the loop you see.  The
> second phase is the transform application.  TreeTransform.apply does
> bzrlib.ui.ui_factory.nested_progress_bar(), so no progressbars are passed.

Ok, that makes sense. Calling pb has a cost though - does that loop take
more than [say] 0.5 seconds to complete on huge trees ? if not, then I
would say 'dont use a pb here' - other wise its 

+1 

from me

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060407/eca6515f/attachment.pgp