[REVIEW] PRoposed fix (Re: post-test failures in bzr.dev)

Robert Collins robertc at robertcollins.net
Fri Apr 7 02:39:43 BST 2006


On Thu, 2006-04-06 at 23:28 +0200, Olaf Conradi wrote:
> Hi
> 
> This will remove the handler from the internal handler list inside
> python's logging module, preventing logging.shutdown() of closing it
> twice.
> 
> Mergable from
> http://deschacht.student.utwente.nl/bzr/bazaar-vcs/bzr.olaf.logging/

Should that be in the opposite order - close and remove, not remove and
close ?

Also, flush() is not needed - close flushes.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060407/a8656e00/attachment.pgp 


More information about the bazaar mailing list