[MERGE] knit performance improvements

Robert Collins robertc at robertcollins.net
Tue Apr 4 03:21:05 BST 2006


On Mon, 2006-04-03 at 17:08 +1000, Robert Collins wrote:
> On Mon, 2006-04-03 at 17:00 +1000, Martin Pool wrote:
> > On  3 Apr 2006, Robert Collins <robertc at robertcollins.net> wrote:
> > > This patch makes knits more performant in a number of ways.
> > > 
> > > It contains:
> > >  * A tweak to missing that I commited in here by mistake which defers
> > > taking write locks unless needed.
> > >    (I'll update that to not conflict with Aarons patch if his has been
> > >     merged).
> > >  * Various microoptimisations to knit and gzip - reducing function call 
> > >    counts in inner loops, reducing double-handling of data, increasing
> > >    knit header parsing performance, removing 'list.index' calls
> > >    completely etc.
> > >  * changes the data format of knits to remove an extraneous \n in the 
> > >    compressed content data, which lets it be trivially pulled into 
> > >    memory in a single 'readlines()' call.
> > 
> > Does this mean it's incompatible with any existing knits people might
> > have?  (It's ok if it is since it's still experimental -- I just
> > wanted to check.)
> 
> Yes. Its the last such change I have planned, other than nagging you to
> get the stores escaping in.

Ping - was that a yes or a no to merging this ?

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060404/df2b1cf0/attachment.pgp 


More information about the bazaar mailing list