[MERGE] Handle lock contention on NFS

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Tue, 2006-03-28 at 16:39 -0500, Aaron Bentley wrote:
> 
> This is missing the blank line before the first method in the class:
> 
> class Foo:
>    '''docstring'''
> 
>    def foo(self):

Oh.  I thought you'd said that a docstring was an alternative to an
initial blank line.

> Have you considered making this a decorator rather than a subclass - a
> trivial amount of currying would let you then apply this to
> MemoryServer/SFTP/Local etc and would IMO simplify the changes to
> support this - MemoryServer would not need to change at all.

No, I don't understand what you mean.

> +0 from me - I'm ok with it as is, but I think its making the
> MemoryTransport/MemoryServer slightly less maintainable and that we can
> do it more nicely.

Well, it looks like classic programming-by-difference to me: just
overriding the behavour you want to change.

> If you are interested in making it a decorator but not completely sure
> of what I mean, I'll be happy to do a variation on that part of the
> patch that does this.

Yes, that would be interesting.  Also, it would be nice to make it a
subclass of LocalTransport if that's possible.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEKqIw0F+nu1YWqI0RAuwjAJ96nTG8nW8y13yE2n4YiHGVIWkwnwCfQYAi
MnJlMXfUqWmLR4pcSRi3ujM=
=Ro66
-----END PGP SIGNATURE-----