[MERGE REVIEW] --remember

Olaf Conradi olaf at conradi.org
Wed Mar 29 15:47:12 BST 2006


On 29/03/06, Robert Collins <robertc at robertcollins.net> wrote:
> On Wed, 2006-03-29 at 04:10 +0200, Olaf Conradi wrote:
> >  * Removes exception AmbiguousBase as it wasn't used
>
> Removing things should be done cautiously: Are you -sure- there are no
> plugins that raise this? or even just import it?
>
> What about a replacement object that will trigger a Warning as well as
> being the exception ?

Ok, fair enough.

How about replacing it with:

class AmbiguousBase(BzrError):
    def __init__(self, bases):
        warn("BzrError AmbiguousBase has been deprecated as of bzrlib 0.8.",
                DeprecationWarning)
        msg = "The correct base is unclear, becase %s are all equally close" %\
            ", ".join(bases)
        BzrError.__init__(self, msg)
        self.bases = bases


Cheers
 -Olaf




More information about the bazaar mailing list