[MERGE REVIEW] Commit handles locking problems better

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 17 Mar 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> 
> 
>>Hi all,
>>
>>This patch ensures that commit throws the correct exception when it
>>encounters an error locking the master branch.
> 
> 
> +1 for the test.
> 
> I guess the code change is OK too, though the way in which the lock is
> acquired and released is a bit convoluted.  I suppose this is an
> improvement and we can clean it more later.

I agree it's not pretty, but there's a bug and this solves it, so I
think it's better in than out.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEIBEd0F+nu1YWqI0RAgLHAJ4noO4q4eZyfEZ3ihOG8PAGf8EaEgCff71s
KqFxmnui2ZyFsQYzE5caX/g=
=xFfJ
-----END PGP SIGNATURE-----