[MERGE REVIEW] repository UI mark II
Martin Pool
mbp at sourcefrog.net
Tue Mar 21 11:16:01 GMT 2006
On 18 Mar 2006, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> I've done more work on the repository UI. This roll-up patch
> 1. adds the command 'init-repository' to create repositories
> 2. teaches the 'init' command to use a shared repository if available
> 3. teaches the 'branch' command to not create a working tree if the
> repository has working trees disabled.
+1, looks good to me.
For naming: i think 'make-X' implies that a new X will be created,
whereas 'init-X' implies an existing one will be initialized. (You can
see this pattern with the names new/init in some .init() methods in oo
languages, including Python.) Since this new command makes a new
directory and init(-branch) does not(?), perhaps they should be named
differently. But I'm happy to merge it without waiting for a naming
debate.
Please add something to the NEWS file too.
--
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060321/75b60e7b/attachment.pgp
More information about the bazaar
mailing list