[MERGE REVIEW] Merge against '.' works properly

Robert Collins robertc at robertcollins.net
Sun Mar 19 08:49:26 GMT 2006


On Sat, 2006-03-18 at 18:46 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> | On Sun, 2006-03-12 at 20:59 -0500, Aaron Bentley wrote:
> |
> |>-            raise Exception("can't fetch from a branch to itself %s,
> |>%s" %
> |>-                            (self.base, to_branch.base))
> |>+            raise errors.CantFetchSelf(self)
> |
> |
> |
> | I think this should be a no-op rather than raising an exception. What do
> | you think?
> 
> Fine with me, here's a patch that does that.
> 
> Or see http://code.aaronbentley.com/bzr/bzrrepo/bzr.mergeself/

+1 if you can explain what the exception is being added for :)

I'm much better now, starting to catch up on the lists.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060319/77363baf/attachment.pgp 


More information about the bazaar mailing list