[MERGE REVIEW] win32 tests
Aaron Bentley
aaron.bentley at utoronto.ca
Sun Mar 12 22:56:52 GMT 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi all,
I've tried running the test suite under win32. I've found a few bugs in
bzr, and some in the test suite. Patch attached, or see bzr.ab.
1. The local transport was returning 0 from append, because tell doesn't
work on a freshly-opened file. Fixed by seeking.
2. ConfigObj opens files in text mode, causing them to be written with
DOS line-endings on win32. To date, all of our files have used Unix
line endings, and I'd rather leave it that way.
3. One test assumed the temp directory was /tmp/
4. A couple of tests did mkdir(config_dir), instead of
ensure_config_dir_exists, which creates *two* directories on win32.
5. Some tests expected os.getcwd to use '/' as a path separator.
6. 'bzr missing' could not accept '.' as an argument.
7. The instrumented ConfigObject's write method didn't a parameter.
8. Some tests built trees using 'native' encoding, and then expected
them to have unix file endings.
Why does build_tree default to 'native', anyway? IMHO, it should write
exactly the specified contents to disk.
53 tests aren't passing, but I think they may be due to path-length
problems. Some of our test names are very long, resulting in paths near
255 characters long.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFEFKc00F+nu1YWqI0RAs7hAJwN9EhB2W5etpMkAFqwNTOIfMSVlQCfUTTm
Df6wDImSgoKqlActxXBw1ps=
=98uC
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: win32tests.patch
Type: text/x-patch
Size: 9315 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060312/74ae9b9d/attachment.bin
More information about the bazaar
mailing list