[MERGE] knits use revision-store-graph

[Robert Collins]

On Fri, 2006-03-10 at 11:30 +1100, Martin Pool wrote:
> 
> The name 'make_working_trees' strongly implies to me that it actually
> makes the working tree.  It might be better to call it
> set/get_working_tree_policy or even working_tree_creation_policy.
> This should be fixed before merge.  (If you think the change is OK  
> but need to
> leave then I can do it.)

The function already existed, but I agree the name can have the
connotation and is better changed for clarity. It should not be a
property because it is not a cheap test, it requires a roundtrip.

> The changes for fileid_involved_between_revs and get_revision_graph
> look
> reasonable, assuming they're already sufficiently tested.
> 
>  > +    def _get_revision_vf(self):
>  > +        """helper to get the revision store versioned file."""
>  > +        vf = self._revision_store.get_revision_file 
> (self.get_transaction())
>  > +        return vf
>  > +
> 
> Maybe change the docs to something like "Return the VersionedFile  
> holding all
> revision headers."

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060310/2e79b941/attachment.pgp