attn: robey - urgentish paramiko bug

[Robert Collins]

 time ../../versioned-file-performance/bzr branch
sftp://people.ubuntu.com/home/robertc/public_html/baz2.0/integration.asknit ../integration-from-sftp
bzr: ERROR:
exceptions.AssertionError:                                         
  at /usr/lib/python2.4/site-packages/paramiko/sftp_file.py line 92
  in _read_prefetch
Killed by signal 1.




Robey, this occurs with prefetch on, and I'm testing w/prefetch off but
it looks happier already.

This is with knits which use Transport.readv heavily:
f = self.get(foo)
f.seek(distance)
f.read(length)

  File
"/home/robertc/source/baz/versioned-file-performance/bzrlib/fetch.py",
line 155, in _fetch_weave_texts
    file_ids = self.from_repository.fileid_involved_by_set(revs)
  File
"/home/robertc/source/baz/versioned-file-performance/bzrlib/repository.py", line 330, in fileid_involved_by_set
    return self._fileid_involved_by_set(changes)
  File
"/home/robertc/source/baz/versioned-file-performance/bzrlib/repository.py", line 362, in _fileid_involved_by_set
    for line in w.iter_lines_added_or_present_in_versions(changes):
  File
"/home/robertc/source/baz/versioned-file-performance/bzrlib/knit.py",
line 535, in iter_lines_added_or_present_in_versions
    for version_id, data, sha_value in \
  File
"/home/robertc/source/baz/versioned-file-performance/bzrlib/knit.py",
line 949, in read_records_iter
    for (record_id, pos, size), (pos, data) in zip(records, response):
  File
"/home/robertc/source/baz/versioned-file-performance/bzrlib/transport/__init__.py", line 256, in readv
    yield offset, fp.read(size)
  File "/usr/lib/python2.4/site-packages/paramiko/file.py", line 148, in
read
    new_data = self._read(max(self._bufsize, size - len(self._rbuffer)))
  File "/usr/lib/python2.4/site-packages/paramiko/sftp_file.py", line
100, in _read
    return self._read_prefetch(size)
  File "/usr/lib/python2.4/site-packages/paramiko/sftp_file.py", line
92, in _read_prefetch
    assert k[0] <= self._realpos



its trying to prefetch through the inventory.knit.

Cheers,
Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060309/c173bba4/attachment.pgp