[RFC] merge - common_ancestor generation

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> I'd like to alter common_ancestor generation via changing combined_graph
> to use the weave prelude of each repository rather than reading the
> revision files: except in the presence of ghosts the information will be
> identical with the proposed consistency check I've put forward in my
> reconcile branch.

I can't find any merge request for your common_ancestor changes, yet the
code has hit the mainline.

I was +1 on the concept, but I am -1 on this implementation, because
you've changed the behaviour of revision_graph.  It has clients that
expect it to refer to ghosts, as I told you.  With your changes, there
is no way to produce a revision graph with ghosts.

I would prefer that you supply a new operation for
revision_graph_without_ghosts, and make common_ancestor use *that*, or
at the very least, provide the old behaviour in a
revision_graph_with_ghosts function.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEDEXr0F+nu1YWqI0RArA6AJ48iZ2J+KKnM9d/wieFN1RrBXosfgCeIruS
XbXcsOH4wZQ6iAasDgwDveE=
=wovi
-----END PGP SIGNATURE-----