Lobbying for -p1 diffs

[Robert Collins]

On Wed, 2006-03-01 at 17:23 -0600, Matthew D. Fuller wrote:
> On Thu, Mar 02, 2006 at 10:10:32AM +1100 I heard the voice of
> Michael Ellerman, and lo! it spake thus:
> > 
> > But seriously, what's your objection to -p1 ? You don't have a '1'
> > key ?
> 
> Heck yeah.  It takes forever to type
> % patch -p`sh -c 'echo $((3-2))'`
> 
> 
> But more, it's:
> 
> - Why should I *HAVE* to type a -p to patch, when I just made the
>   diff?  -p is for munging diffs from other sources when necessary,
>   not as a standard step for your own!

-p0 is currently needed to interpret all bzr diffs, because patch
defaults to pathless operation. And bzr patch will DTRT naturally.

> And more immediately,
> 
> - 95% or better of my use of diff isn't intended for patch, it's
>   intended for my eyes.  Having those extra dirs there means I need to
>   stop, and carefully read and interpret those lines to figure out
>   what they mean, instead of just a quick glance to tell me where I
>   am.

Thats more of a concern. I'm not sure of the impact though, I've never
had a problem with orig/ and mod/ prefixes in other systems.

Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060302/9ac0ee85/attachment.pgp