[MERGE REVIEW] fixes for cmd_diff and checkouts

[John Arbash Meinel]

Aaron Bentley wrote:
> Hi all,
> 
> Part two of my 'making checkouts work' series is making diff work.
> 
> Ironically, these two commands, which don't actually do anything, are
> the ones that were most broken for checkouts.  I've done an audit of all
> the places we use BzrDir.open_workingtree, and I can't see anything else
> that looks dangerous.
> 
> Patch attached, or see bzr.ab
> 
> Aaron

(Re-sending)

+1 on the changes. My only concern is the new function name. You called
it "cmd_show_diff" which makes it sound like it should be a command line
function. "bzr show-diff".

I realize you need a unique name, and we already have 'show_diff'
(deprecated) and 'show_diff_trees'.

I would also name the parameters "old_revision_spec" rather than
"old_revision". Because it isn't a Revision object or a revision_id, it
is a spec to search in the tree for that revision.

At least that is how the code seems to be written.

John
=:->




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060227/e7b7fb9b/attachment.pgp