[Bug 32526] uncommit -r off by one

[John Arbash Meinel]

James Blackwell wrote:
> Public bug reported:
> https://launchpad.net/malone/bugs/32526
> 
> Affects: bzr (upstream)
>        Severity: Normal
>        Priority: (none set)
>          Status: Unconfirmed
> 
> Description:
> As of revision 1543 runnin "bzr uncommit -r revno" is off by one
> revision. If one wants to return to revsision "1528" then one needs to
> specify revision "1529"
> 

That is actually the design. 'uncommit -r' is saying 'uncommit this
revision', versus 'revert' which is saying 'revert *to* this revision'.

Now, I can agree that the distinction is minor. And I've found myself
saying "uncommit *to* this revision". So we may want to change the
semantics of the command.

I'm sending this to the mailing list so that we can have a discussion
about what 'uncommit -r' should mean.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060222/00656523/attachment.pgp