[patch] add Transport.rename
Robey Pointer
robey at lag.net
Tue Feb 21 07:17:05 GMT 2006
On 20 Feb 2006, at 21:32, John A Meinel wrote:
> Martin Pool wrote:
>> On Mon, 2006-02-20 at 18:58 -0800, Robey Pointer wrote:
>>
>>> +1 also.
>>
>> OK, I'll see about merging that across into bzr.dev.
>>
>>> The default implementation in base Transport will be buggy,
>>> though (since the 2 different operations are implemented
>>> identically).
>>
>> Perhaps I should leave it unimplemented in the default Transport
>> then,
>> and force writable transports to implement it.
>>
>
> The only problem I have with adding it to Transport instead of a
> separate function, is that it is currently used as osutils.rename() on
> win32. This is because all of the merge code which uses atomic replace
> needs it.
I still think that means it should be used by LocalTransport on
Windows, not exposed external to Transport.
robey
More information about the bazaar
mailing list