[patch] add Transport.rename

John A Meinel john at arbash-meinel.com
Tue Feb 21 05:32:36 GMT 2006


Martin Pool wrote:
> On Mon, 2006-02-20 at 18:58 -0800, Robey Pointer wrote:
> 
>> +1 also.  
> 
> OK, I'll see about merging that across into bzr.dev.
> 
>> The default implementation in base Transport will be buggy,  
>> though (since the 2 different operations are implemented identically).
> 
> Perhaps I should leave it unimplemented in the default Transport then,
> and force writable transports to implement it.
> 

The only problem I have with adding it to Transport instead of a
separate function, is that it is currently used as osutils.rename() on
win32. This is because all of the merge code which uses atomic replace
needs it.

But otherwise +1 on the changes to Transport to add '.rename()'.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060220/1a045d9b/attachment.pgp 


More information about the bazaar mailing list