[RFC][PATCH]Speed improvement on the http transport: add keepalive support

[John A Meinel]

Goffredo Baroncelli wrote:
> Hi all, 
> 
> this mail is a resend because the previous one seems to have some problem with 
> my gpg sign....
> 
> the patch below adds the capability to make multiple request per connection on
> the http transport. The patch includes the file keepalive.py from the 
> urlgrabber library in order to avoid another dependency issue.
> 
> Below a bench on my machine ( Duron 800Mhz, with *local dns* & *local http server* )
> 
> $ time bzr.dev/bzr branch http://kreijack.homelinux.net:8077/bazaar/bazaar-ng_stable_branch
> Branched 1528 revision(s).
> 
> real    4m50.499s
> user    2m14.577s
> sys     0m27.440s
> 
> $ time multiple-http-request/bzr branch http://kreijack.homelinux.net:8077/bazaar/bazaar-ng_stable_branch
> Branched 1528 revision(s).
> 
> real    3m1.507s
> user    1m32.812s
> sys     0m14.980s
> 
> note the user time which with the patch decreases from 2m14 to 1m32.
> 
> The patch is posted for a review, comments are welcome.
> 
> Goffredo

If you are copying code from another project, it generally goes into
'bzrlib.util'.
And we used to actually use URLGrabber. I believe we stopped using it
because it failed to work properly on Windows. And we preferred having
only 1 code path. (I believe Aaron was the one who pushed for this).

I think Martin has a branch which would use pyCurl which supports
keep-alive and some other good stuff (as long as you have curl installed).

So I'm not opposed to this, but I have the feeling someone else has
already looked into it, and thought urlgrabber wasn't the way to go.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060216/2759d5bd/attachment.pgp