[bug] Repository.copy() copies inventory first

[Robert Collins]

On Thu, 2006-02-16 at 14:36 -0600, John A Meinel wrote:
> Robert Collins wrote:
> > +1
> > Rob
> 
> Do I have a +1 on sign-my-commits? Also on jam-pending.
> 
> Then I can bring them both in.

+
+"""Black-box tests for bzr sign-my-commits.
+"""
+


Should be

+
+"""Black-box tests for bzr sign-my-commits."""
+


You might like to use TestCaseWithTransport which offers
'self.make_branch_and_tree('.'). This api will use different transport
for the branch and repo when requested to, so can give better testing
coverage.


+             pb = bzrlib.ui.ui_factory.progress_bar()
+             copy_all(self.weave_store, destination.weave_store, pb=pb)
+             pb.update('copying inventory', 0, 1)
              destination.control_weaves.copy_multi(self.control_weaves,
                                                   ['inventory'])
-             copy_all(self.weave_store, destination.weave_store)
-             copy_all(self.revision_store, destination.revision_store)
+             copy_all(self.revision_store, destination.revision_store,
pb=pb)

I think you've added an 80-char with PEP violation there. Also, doesn't
'destination.control_weaves.copy-multi()' want 'pb=pb' passed to it ?


=== modified file 'bzrlib/store/__init__.py'
--- bzrlib/store/__init__.py    
+++ bzrlib/store/__init__.py    
@@ -35,6 +35,7 @@
 from bzrlib.trace import mutter
 import bzrlib.transport as transport
 from bzrlib.transport.local import LocalTransport
+import bzrlib.ui

Seems to be an unused import ?


Other than that, +1.

Rob



	

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060217/08932d69/attachment.pgp