[MERGE] Bug fix for bzr log -r ..x

John A Meinel john at arbash-meinel.com
Thu Feb 16 01:08:57 GMT 2006


Michael Ellerman wrote:
> On 2/16/06, John A Meinel <john at arbash-meinel.com> wrote:
>> Michael Ellerman wrote:
>>> On 2/16/06, John A Meinel <john at arbash-meinel.com> wrote:
>>>>> Pullable from http://michael.ellerman.id.au/files/bzr/mpe
>> Well, here is a review of the changes.
>>
>> in test_help.py you have the name of the class as TestLog, and you need
>> an extra newline before the class definition.
> 
> Doh, copy and paste strikes again. Why do I need an extra newline
> before the class def? Is that PEP8, "must have two blank lines between
> import and class def" ??
> 

Yes.

>> I didn't even realize 'bzr ?' would work. Do we want this alias?
> 
> Yeah me neither :) - I think it's kinda nice, and pretty harmless.
> 
> cheers
> 

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060215/22a39883/attachment.pgp 


More information about the bazaar mailing list