Serializer_v5._pack_revision and _unpack_revision to become public?

John A Meinel john at arbash-meinel.com
Wed Feb 15 23:18:02 GMT 2006


Denys Duchier wrote:
> John A Meinel <john at arbash-meinel.com> writes:
> 
>> If you can find the specific reasons why we are slow please do so. I
>> have the feeling it is just the time to parse XML.
> 
> In all my tests, parsing xml has always turned out to be essentially negligible.
> with cElementTree, it is really fast.  Other things tend to dominate, like
> computing the set of inclusions for a given revision in preparation for weave
> extraction.  If you can reasonably speed _that_ up (at least for typical use
> cases) then you might see some significant return on your investment
> effort-wise.
> 
> --Denys

Well David was saying that it is expensive to get revisions. But that
should only be reading XML files. repository.get_revision() doesn't have
to do anything but read XML.

I realize that our overall performance is actually usually limited by
O(n_lines) performance of weaves (especially for the inventory).
And _extract tends to dominate times.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060215/fc2f091a/attachment.pgp 


More information about the bazaar mailing list