adapt_modules interfering with cleanup?

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

It looks like adapt_modules is interfering with the cleanup of tests.
That is, I have a test in bzrtools which fails because it makes
assumptions about the cwd.

Demonstrating this test requires the latest bzr.ttransform.  I'm not
sure why, yet.

e.g. bzr selftest '(rsync|d[(]RepositoryFormat4[)]$)' will produce
Failed example:
    rsync("a", "b", silent=True)
Expected:
    Traceback (most recent call last):
    RsyncNoFile: No such file a
Got:
    ['rsync', '-av', '--delete', 'a', 'b']
- ----------------------------------------------------------------------
File "/home/abentley/.bazaar/plugins/bzrtools/bzrtools.py", line 119, in
bzrlib.plugins.bzrtools.bzrtools.rsync
Failed example:
    rsync("a", "b", excludes=("*.py",), silent=True)
Expected:
    Traceback (most recent call last):
    RsyncNoFile: No such file a
Got:
    ['rsync', '-av', '--delete', '--exclude-from', '-', 'a', 'b']

Running bzrtools by itself doesn't  cause any test failures.  It looks
as though when TestSkipped is raised and the module is an adapted one,
cleanup doesn't run.  But cleanup normally does run when TestSkipped is
raised.

I've been unable to reproduce the bug in a test case, so far.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD82QY0F+nu1YWqI0RAnwjAJ9bR2vgratLXgwulbopbvSNxdO/9QCfXVuj
neClWUfpKEzt8UO2W///tT8=
=P+zh
-----END PGP SIGNATURE-----