[MERGE] bzr.ab

John A Meinel john at arbash-meinel.com
Mon Feb 13 21:03:17 GMT 2006


Aaron Bentley wrote:
> Because my command defaults change won't be going in, and because Tree
> Transform needed to back out some of the changes, I've recommitted my
> work in bzr.ab
> 
> I believe all of these changes are no-brainers.  Could someone please
> integrate them?
> 

Taking these one by one:

 1527 Aaron Bentley     2006-02-13
      recommit 1527 PEP8 fixes
+1


 1528 Aaron Bentley     2006-02-13
      Fix find-merge-base for new API [recommit]
+1


 1529 Aaron Bentley     2006-02-13
      Removed lock-related log spam [recommit]
+1 from me, though I'm not sure how Robert or Martin feels


 1530 Aaron Bentley     2006-02-13
      Merge bzr.dev
(not reviewed :)


 1531 Aaron Bentley     2006-02-13
      Removed more selftest spam [recommit]
+1, though it would mean we try to fix this sooner :)


 1532 Aaron Bentley     2006-02-13
      Restored blackbox tests [recommit]
I had already restored blackbox tests (and improved the blackbox loading
code to act like the tests loading code [so import errors get reported
properly]) So this might conflict, but I have no problem merging it, and
resolving the conflict.


 1533 Aaron Bentley     2006-02-13
      Test case for discrepancy between fileid_involved and compare_tree
[recommit]

We probably should put an extra space above FileIdInvolvedBase.
But more importantly, why do you feel that compare_trees() should return
a superset compared with file_id_involved_between_revs? You had a
specific reason, if you can repeat it, it would help me.

So overall +1 if you can give me an explanation of why file_id_involved*
should not return all the entries that compare_trees returns.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060213/a4eca8cd/attachment.pgp 


More information about the bazaar mailing list