[RFC] support for plugins to implement their own log formatters

[John A Meinel]

Erik Bågfors wrote:
>>> I don't know about set_default_formatter.  AFICT, its purpose is to
>>> allow plugins to control the setting, but a user may have a plugin
>>> installed without wanting to change their default.
>> Agreed.  That was something I was unsure about as well (but forgot
>> when I wrote the mail)
>>
>> Shall I remove it? I'm fine with that.
>>
>>> Are you doing this because you're concerned about having to set the
>>> defaults separately for each command that uses log formatters?  I
>>> certainly don't have a problem with a global log-formatter-default option.
>> Sounds good. I wasn't thinking about the default thing since that's
>> not in bzr.dev yet afaik...
> 
> Now, you can set the default formatter in the configuration.  A plugin
> cannot (easily) change the default formatter. Branch in the same
> place.
> 
> Any more comments?
> 
> Regards,
> Erik

In one place you use:

default = bzrlib.config.BranchConfig(b).log_format()

in another you use:

default = bzrlib.config.BranchConfig(local_branch).log_formatter()

I have a feeling one of them is wrong. Which also indicates that they
aren't both tested.

Otherwise, I like the idea that we can have plugins register new log
formatters. And the code is relatively clean. +1 if you add tests, and
fix the bug.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060212/f250b9dc/attachment.pgp